[CODE REVIEW] PrimePush2.0: "evenBus" config property

UI Components for JSF
Post Reply
smithh032772
Posts: 6144
Joined: 10 Sep 2011, 21:10

13 Apr 2014, 12:55

r11052 (Try to avoid using the static EvenBus as much as possible in case more than one
PushServlet gets deployed) includes the following:

PushServlet.java - Line 89 - "evenBus" or "eventBus" (even or 'event')?

Code: Select all

        EventBus e = new EventBusImpl();
        EventBusFactory f = new EventBusFactory(e);
        framework.getAtmosphereConfig().properties().put("evenBus", e);
and

PushEndpointHandlerProxy.java - Line 137 - "evenBus" or "eventBus" (even or 'event')

Code: Select all

this.eventBus = (EventBus) config.properties().get("evenBus");
why 'evenBus'? this property should be consistent with the 'EventBus', so the property should be 'eventBus'.
Howard

PrimeFaces 6.0, Extensions 6.0.0, Push (Atmosphere 2.4.0)
TomEE+ 1.7.4 (Tomcat 7.0.68), MyFaces Core 2.2.9, JDK8
JUEL 2.2.7 | OmniFaces | EclipseLink-JPA/Derby | Chrome

Java EE 6 Tutorial|NetBeans|Google|Stackoverflow|PrimeFaces|Apache

jfarcand
Posts: 19
Joined: 02 Feb 2010, 20:23

14 Apr 2014, 15:48

This property is internal...true it should be eventBus, but that won't change the behavior and this property won't never be exposed to user :-)

kukeltje
Expert Member
Posts: 9605
Joined: 17 Jun 2010, 13:34
Location: Netherlands

14 Apr 2014, 18:42

Howard found it... So watch out... He'll start (ab)using it sooner rather then later :-D

smithh032772
Posts: 6144
Joined: 10 Sep 2011, 21:10

14 Apr 2014, 20:22

kukeltje wrote:Howard found it... So watch out... He'll start (ab)using it sooner rather then later :-D
hey, you are using PrimeFaces Push 2.0 'now', and I am not (yet).

Abusing it? nope, not me. Using it, hopefully so. :)
Howard

PrimeFaces 6.0, Extensions 6.0.0, Push (Atmosphere 2.4.0)
TomEE+ 1.7.4 (Tomcat 7.0.68), MyFaces Core 2.2.9, JDK8
JUEL 2.2.7 | OmniFaces | EclipseLink-JPA/Derby | Chrome

Java EE 6 Tutorial|NetBeans|Google|Stackoverflow|PrimeFaces|Apache

Post Reply

Return to “PrimeFaces”

  • Information
  • Who is online

    Users browsing this forum: No registered users and 17 guests