Design Discussions

[Oleg]

We've decided to follow PrimeFaces and to force value escaping in "forSelector" by user . Even if it's an ID. Only value in "for" should be escaped by comp. library.

[Oleg]

Cagatay, what this.jq.data('primefaces-widget', this); in BaseWidget is good for?

Edit: I see it's only used for DataTable, Tree and TreeTable, but placed in BaseWidget?

[cagatay.civici]

Only datatable, tree and treeTable has this data attribute, used by contextMenu. ContextMenu calls widget apis of these components.

See bindDataTable for example.

It was in base once but now only for components that need it.

[cagatay.civici]

I've created p:resetInput by the way. It doesn't support ClientBehaviorHolders-AjaxBehaviors right now, maybe in the future if there is demand.

Also RequestContext has reset method for programmatic reset.

I've also taken this to Expert Group, it got some attention, we'll see how it goes.

[tandraschko]

cool!
hopefully you can bring it to JSF API!

[Oleg]

Please don't bring it to JSF API as a standard behavior. There are cases where this behavior is not desired, as I stated in this issue http://java.net/jira/browse/JAVASERVERF ... UBLIC-1060 So, having custom component is the best solution for me.

By the way, what was the need to add p:resetInput? We already have pe:resetInput and this can confuse users. In general, I think duplicate components can confuse users if they don't bring new / complementary features, but are only subsets of each other. I can kinda understand OmniFaces that they copied ImportConstants. Not good, but useful for users that don't use PrimeFaces. I don't worries much about code coping, I worry about duplicate components. We dropped actually developed / in developing / in planning SelectCheckboxMenu (although selected items are still not seen), ProgressBar (although tooltip is still missing), Tree (in hope PF's one will have drag & drop), RequiredLabel, AjaxStatus, targetable Message(s), Growl, ... can not remember what yet ... Paginator is dropped too. These duplicate components can't be removed currently (but maybe in the future): BlockUI, ResetInput. These duplicate components will be never removed: Layout, Tooltip.

[cagatay.civici]

My colleagues who are working on a project asked me for p:resetInput. They are not using extensions or omnifaces so they need it. I added it as a last minute feature for my team.

[Oleg]

Ok.

Another question yet. Do you plan to bring PrimeFaces to the Maven central repo and if yes when?

[cagatay.civici]

When I have the free time frankly.

[Oleg]

Maybe you need an official issue in bug tracker for that