New carousel padding/margin are off.

[djmj]

The padding/margin of upcoming carousel are a little bit off since basic ui-panel uses 0.2em padding and new carousel uses fixed 1px.

Suggestions:

Except a little right margin of the last visible item all paddings and margins are same as from other container components.

Code: Select all

.ui-carousel
{
    padding: 0.2em; // or use ui-panel class
}

.ui-carousel .ui-carousel-viewport 
{
    margin: 0.2em 0;
}

.ui-carousel .ui-carousel-viewport .ui-carousel-items .ui-carousel-item
{
    margin-right: 0.2em;
}

.ui-carousel .ui-carousel-footer 
{
    // remove margin definition
}

.ui-carousel .ui-carousel-header 
{
    // remove margin definition
}

Preview:

[kukeltje]

I don't see this in FF 39...

[djmj]

I see it in FF 39. Screenshot. Borders are very close to each other.



created issue: https://github.com/primefaces/primefaces/issues/513

[kukeltje]

That is what I indeed see. I just compared with your initial image which differs.