Ajax response charset problem PATCH

[monakhv]

Hi, All!

Recently two ajax charset response problem have been discovered.
See http://primefaces.prime.com.tr/forum/vi ... f=3&t=1312
and
http://primefaces.prime.com.tr/forum/vi ... f=3&t=1304

After code digging I've found the problem in org.primefaces.application.PrimeFacesPhaseListener class
in the method initPartialResponseWriter. It set character encoding for the response writer but not for response itself.
The character encoding for the response will be always ISO-8859-1!

The correct method code is below

Code: Select all

private void initPartialResponseWriter(FacesContext facesContext) {
		if(facesContext.getResponseWriter() != null)
			return;
		
		try {
			ServletResponse response = (ServletResponse) facesContext.getExternalContext().getResponse();
			ServletRequest request = (ServletRequest) facesContext.getExternalContext().getRequest();
			response.setCharacterEncoding(request.getCharacterEncoding());
			RenderKit renderKit = facesContext.getRenderKit();
			ResponseWriter responseWriter = renderKit.createResponseWriter(response.getWriter(), null, request.getCharacterEncoding());
			facesContext.setResponseWriter(responseWriter);
		}catch(IOException exception) {
			exception.printStackTrace();
		}
	}

I add the only line

Code: Select all

response.setCharacterEncoding(request.getCharacterEncoding());

[cagatay.civici]

I'll look into this today, thanks for the patch. This might help fixing chartset issues without a servlet filter.

[Oleg]

I'll look into this today, thanks for the patch. This might help fixing chartset issues without a servlet filter.

Please look into this issue, Cagatay. It's a big problem for us too because some german characters (umlauts) cause empty page (nothing is rendered). Although request character encoding has UTF-8 I always get ISO-8859-1 in the response. I've debugged this problem. The patch above helps us.

At the moment I've buit in a workaround with entities. For instance a sign ü has to be coded as ü ä as ä etc.

Thanks. Oleg.

[Oleg]

I've checked it again. Only PATCH can help us. Without patch we can not use partial update and other languages except english because nothing appears (empty page area to be updated). But just single line and it works fine

Code: Select all

response.setCharacterEncoding(request.getCharacterEncoding());

Is there a ticket in the issue tracker? This is a very urgent bugfixing. Maybe you could put this line this week. We would use then 2.0.1-SNAPSHOT from your repository. Thanks!

[monakhv]

Is there a ticket in the issue tracker? This is a very urgent bugfixing. Maybe you could put this line this week. We would use then 2.0.1-SNAPSHOT from your repository. Thanks!

Hi, Oleg!

I did not create the issue tracker in the tracker system. The issue is resolve and patch is published. Everybody can use it.
However it will be nice to put it in main stream PrimeFaces code. This is the question to PrimeFaces developers.

Dmitry.

[Oleg]

Is there a ticket in the issue tracker? This is a very urgent bugfixing. Maybe you could put this line this week. We would use then 2.0.1-SNAPSHOT from your repository. Thanks!

Hi, Oleg!

I did not create the issue tracker in the tracker system. The issue is resolve and patch is published. Everybody can use it.
However it will be nice to put it in main stream PrimeFaces code. This is the question to PrimeFaces developers.

Dmitry.

http://code.google.com/p/primefaces/iss ... %20Summary

[cagatay.civici]

I've updated issue regarding target version and status.

http://code.google.com/p/primefaces/iss ... ail?id=546

This will be checked in today or tomorrow after testing.

Thanks for the feedback everyone!

[cagatay.civici]

This is fixed now, in our PrimeFaces apps we have character encoding servlet filter to enforce charsets so we didn't see the issue in our apps. Now after the fix, it even works without the filter, thanks for the patch and feedback.

[Oleg]

This is fixed now, in our PrimeFaces apps we have character encoding servlet filter to enforce charsets so we didn't see the issue in our apps. Now after the fix, it even works without the filter, thanks for the patch and feedback.

Great! Can we use nightly build 2.0.1-SNAPSHOT?

[cagatay.civici]

Yes sure, starting from tomorrow.