spinner boxes should not have z-axis 100

UI Components for JSF
Post Reply
struberg
Posts: 5
Joined: 17 Feb 2010, 13:02

17 Feb 2010, 13:21

Hi!

I'm almost new to PrimeFaces (tested an early bird a year ago or so) and am evaluating 2.0.1-SNAPSHOT for now (built from latest source).

I experienced a few small problems:

1.) the spinner up/down icons have z-axis 100 which leads to a problem if e.g. a calendar popup opens over them:
Image
Image

In the second image, the spinner up/down boxes are still visible.

This can easily fixed by removing the z-index: 100; css attribute. Not sure yet what side effects this has though. See patch http://pastie.org/828698

2.) The spinner seems to ignore the size="2" attribute

3.) spinner could get minValue, maxValue and rollOver attributes. I dig into the code and hope I'm able to provide patches

Oh for the record: I'm using MyFaces-2.0.0-SNAPSHOT, OpenWebBeans-1.0.0-SNAPSHOT, OpenJPA-2.0.0-beta and EL-2.2

txs and LieGrue,
strub

struberg
Posts: 5
Joined: 17 Feb 2010, 13:02

17 Feb 2010, 14:05

here is a small patch which introduces the minValue and maxValue (rollOver seems to be a bit more work):

http://pastie.org/828746

ASL rights granted for sure.

PS: I'm really surprised how clean the codebase is. Took me only a bit longer than 30 minutes from scratch to add new functionality!

cagatay.civici
Prime
Posts: 18616
Joined: 05 Jan 2009, 00:21
Location: Cybertron
Contact:

18 Feb 2010, 15:57

Great patch thanks, I'll add it to soon.

Thanks for your comment on PrimeFaces codebase, we are trying to keep things clean and lightweight.

cagatay.civici
Prime
Posts: 18616
Joined: 05 Jan 2009, 00:21
Location: Cybertron
Contact:

19 Feb 2010, 13:46

Can you please create a ticket in issue tracker and attach your patch as a subversion patch?

Post Reply

Return to “PrimeFaces”

  • Information
  • Who is online

    Users browsing this forum: Google [Bot] and 69 guests