p:commandButton not working or am I missing something

[grizli]

I have a page with 2-3 text fields (h:inputtext)
below is a p:datatable.
I also have p:commandButton on the page which is set to update="txtfield1, txtfield2, txtfield3, myDatable"
What I'm trying to do is have a user input parameters in text fields and then click on p:commandButton
That way backing bean sets values for text fields, since they are defined as value="#{page.txtField1}" and etc
And then datatable gets refreshed with conditions specified in text fields.

The problem is - no matter which way I try - when p:commandButton is pressed, it always goes through updating datatable first before setting any text fields values.
Is this possible? Is this by design? Or it's not working properly?
Please help

[cagatay.civici]

I couldn't understand the page clearly, can you post the code?

[grizli]

The JSF page:

Code: Select all

<p:accordionPanel><p:tab title="Filters">
Filter Item One: <h:inputText id="FilterFieldOne" value="#{bean.firstFilter}" /><br />
Filter Item Two: <h:inputText id="FilterFieldTwo" value="#{bean.secondFilter}" /><br />
<p:commandButton id="FltBtn" value="Filter" process="FilterFieldOne, FilterFieldTwo" update="myTable" />
</p:tab></p:accordionPanel>
<p:dataTable id="myTable" var="data" value="#{bean.myList}" paginator="true" rows="50" scrollable="true" height="500" width="100%" dynamic="true" widgetVar="cMyTable">
                <p:column id="FirstColumn" sortBy="#{data.firstDataItem}" resizable="true">
                    <f:facet name="header">
                        <h:outputText value="First Column" />
                    </f:facet>
                    <h:outputText value="#{data.firstDataItem}" />
                </p:column>
                <p:column id="SecondColumn" sortBy="#{data.secondDataItem}" resizable="true">
                    <f:facet name="header">
                        <h:outputText value="Second Column" />
                    </f:facet>
                    <h:outputText value="#{data.secondDataItem}" />
                </p:column>
                <p:column id="ThirdColumn" sortBy="#{data.thirdDataItem}" resizable="true">
                    <f:facet name="header">
                        <h:outputText value="Third Column" />
                    </f:facet>
                    <h:outputText value="#{data.thirdDataItem}" />
                </p:column>
</p:dataTable>

Backing bean:

Code: Select all

...
...definitions, getters and setters for firstFilter and secondFilter here...
private List<EachDataItem> myList;
public List<EachDataItem> getmyList() {
        if (myList == null) { myList = new ArrayList(); LoadList(); }
        return myList;
    }
private void LoadList() {
        String SqlStr = "SELECT blabla... FROM blabla WHERE bla1 = '" + getfirstFilter() + "' AND bla2 = '" + getsecondFilter() + "';
        ResultSet rs = SomeClass.getDataSet(SqlStr, false);
        while (rs.next()) { this.myList.add(new EachDataItem(blablablablabla)); }
        SomeClass.CloseSqlConnection();
}

All the blablas - I did not include since it's not very relevant
I hope this helps

[Oleg]

Hello grizli,

I didn't understand why you need an update of input fiels. You have to let pass them through JSF lyfecycle. The following code should work

<p:commandButton value="Filter" process="FilterFieldOne, FilterFieldTwo" update="myTable" />

Or better

<p:commandButton value="Filter" process="FilterFieldOne, FilterFieldTwo" update="myTable" action="bean.doActionForDataTable"/>

bean.doActionForDataTable reads values from bean.firstFilter / bean.secondFilter and does something with list.

Best regards.
- Oleg.

[grizli]

Thank you Oleg,
I changed the update and included process for Filter Fields.
The values now return to the bean properly and getter calls LoadList() which reads the Filter values and re-populates the myList.
For some reason, however, datatable itself did not update on the screen.

[Oleg]

I think, I forgot @this in process. Try this

<p:commandButton value="Filter" process="@this, FilterFieldOne, FilterFieldTwo" update="myTable" action="bean.doActionForDataTable"/>

[grizli]

Thanks again Oleg,
I've tried that as well - no avail. Debuggers shows everything is working properly within the backing bean, but datatable is not getting updated client-side.
Would my environment cause any problems?
I'm running on Glassfish 2.1 + JSF 1.2

[grizli]

I opened up Error Console in FF to see what happens when CommandButton is pressed.
Error Console writes this:
Error: mismatched tag. Expected: </output>.
Source File: http://localhost:8080/TestApp/faces/index.jsp
Line: 15, Column: 3
Source Code:
</script><div><div></div><input /></div>]]></output></component></components><state><![CDATA[<input type="hidden" name="javax.faces.ViewState" id="javax.faces.ViewState" value="very long value here....

[grizli]

Is there a bug with javascript call that suppose to refresh the datatable?

[grizli]

Cagatay, is there a way anyone could look into this? It's critical for the application I'm working on and basically is a show-stopper.
I would imagine, with time, more people will have such filtering approach with datatable (after all, it's already being done with IceFaces) and will run into the same problem.
As I mentioned above - according to debugger everything is working properly. Action in the backing bean re-populates the ArrayList datatable value is binded to, but table simply does not change on the screen.