Dialogs gets Duplicated on update

[francesco.strazzullo]

Hi all,
I've created a CompositeComponet formed by an inputText and a Dialog. When I Update the cc and launch the show() method I see two dialog. I have analyzed the output html and I have found two div with the same id. I have patched the file dialog.js in this way:

PrimeFaces.widget.Dialog.prototype._show = function() {
if(this.cfg.showEffect) {
var _self = this;

this.jq.show(this.cfg.showEffect, null, 'normal', function() {
_self.postShow();
});
}
else {
//display dialog
/*Begin Custom Code*/
var dlg = jQuery(this.jqId);

if(dlg.size() > 1){
dlg.last().remove();
}
this.jq = dlg;
/*End Custom Code*/
this.jq.show();

this.postShow();
}

this.focusFirstInput();
this.visible = true;
this.moveToTop();

if(this.cfg.modal)
this.enableModality();
}

Now when two dialogs are generated, one of them is removed and all seems to work correctly. Is this a bug or is intended to work this way?

[LarsD]

.show() and .hide() are javascript functions which can have side effects like this. Also, in some cases this functions make popUps not working. I prefer not to use them to show a popup, instead you should show/hide them bean controlled.

example:

Code: Select all

<p:dialog widgetVar="dialog"
		visible="#{someBean.dialogVisible}">
...
</p:dialog>

...
<p:commandButton value="Show Dialog" 
action="#{someBean.showDialog}" image="ui-icon ui-icon-gear"
ajax="false" />

The method "showDialog" sets the boolean value "dialogVisible" to true and starts a page update by returning null or the navigation case for this page. After it the dialog is visible without using a single line of JavaScript code.

Lars

[cagatay.civici]

Try 3.x and please read forum posting guide.

[francesco.strazzullo]

Try 3.x and please read forum posting guide.

Sorry Optimus! Here's my configuration

Primefaces: 3.0.M4
Mojarra: 2.1.2
Jboss: 6.0

[francesco.strazzullo]

.show() and .hide() are javascript functions which can have side effects like this. Also, in some cases this functions make popUps not working. I prefer not to use them to show a popup, instead you should show/hide them bean controlled.

example:

Code: Select all

<p:dialog widgetVar="dialog"
		visible="#{someBean.dialogVisible}">
...
</p:dialog>

...
<p:commandButton value="Show Dialog" 
action="#{someBean.showDialog}" image="ui-icon ui-icon-gear"
ajax="false" />

The method "showDialog" sets the boolean value "dialogVisible" to true and starts a page update by returning null or the navigation case for this page. After it the dialog is visible without using a single line of JavaScript code.

Lars

I Cannot use your solution because i have to partially update my page. so my commandButtons has to be ajax=true