p:log and cookie value

[holek]

Hi,

when i use p:log on a page then tomcat shows invalid cookie message every request:

2011-12-07 20:03:17 org.apache.tomcat.util.http.Cookies processCookieHeader
INFO: Cookies: Invalid cookie. Value not a token or quoted value

I think this cookie problematic:
name: blackbird
value: {pos:0,size:0,load:true}

is it a bug?

Tomcat 7.0.23, Primefaces 3.0M4

[smithh032772]

Click URL below.

viewtopic.php?f=3&t=16200&p=50916#p50916

[holek]

Thank you for your answer

Finally, I have changed log.js file from svn trunk to quote blackbird cookie value

here is a patch ( could this be changed in trunk too ? ) :

Code: Select all

@@ -8,7 +8,7 @@
 	The MIT License - Copyright (c) 2008 Blackbird Project
 */
 if ( ! document.cookie.match( /blackbird=/ ) ) {
-    document.cookie = 'blackbird={pos:0,size:0,load:true};';
+    document.cookie = 'blackbird="{pos:0,size:0,load:true}";';
 }
     
 ( function() {
@@ -226,7 +226,7 @@
 		
 		var expiration = new Date();
 		expiration.setDate( expiration.getDate() + 14 );
-		document.cookie = [ 'blackbird={', props, '}; expires=', expiration.toUTCString() ,';' ].join( '' );
+		document.cookie = [ 'blackbird="{', props, '}"; expires=', expiration.toUTCString() ,';' ].join( '' );
 
 		var newClass = [];
 		for ( word in classes ) {
@@ -236,7 +236,7 @@
 	}
 	
 	function getState() {
-		var re = new RegExp( /blackbird=({[^;]+})(;|\b|$)/ );
+		var re = new RegExp( /blackbird="({[^;]+})"(;|\b|$)/ );
 		var match = re.exec( document.cookie );
 		return ( match && match[ 1 ] ) ? eval( '(' + match[ 1 ] + ')' ) : { pos:null, size:null, load:null };
 	}

[smithh032772]

You're welcome, and thanks for your response, which includes a solution to your issue! Others may be able to benefit from your solution!

[tandraschko]

What about creating an issue and append the patch?

[holek]

Issue: http://code.google.com/p/primefaces/iss ... il?id=3010

[smithh032772]

Great idea!

What about creating an issue and append the patch?

Good work! Thanks.

Issue: http://code.google.com/p/primefaces/iss ... il?id=3010

[cagatay.civici]

Log component is reimplemented as a native PF widget instead of using blackbird so this is not valid anymore.