Panel 2.0.1: Where is the attribute headerToggler?

UI Components for JSF
User avatar
Oleg
Expert Member
Posts: 3805
Joined: 02 Oct 2009, 09:41
Location: Germany, Black Forest

23 Apr 2010, 16:07

Hello,

Where is the attribute "headerToggler" for the PrimeFaces Panel? I miss it since the last release. I had headerToggler="true" for all my panels (+ tooltips about this behavior!). And now panels are not toggleable by click on panel headers. Is it a small regression?

Thanks.
PrimeFaces Cookbook (2. edition): http://ova2.github.io/primefaces-cookbook/ Learning Angular UI Development with PrimeNG: https://github.com/ova2/angular-develop ... th-primeng Blog: https://medium.com/@OlegVaraksin

User avatar
Oleg
Expert Member
Posts: 3805
Joined: 02 Oct 2009, 09:41
Location: Germany, Black Forest

23 Apr 2010, 16:15

I have found the line

Code: Select all

		if(panel.isToggleable() && panel.isHeaderToggler()) {
			writer.writeAttribute("onclick", var + ".toggle();", null);
		}
doesn't exist more. Unlucky refactoring?
PrimeFaces Cookbook (2. edition): http://ova2.github.io/primefaces-cookbook/ Learning Angular UI Development with PrimeNG: https://github.com/ova2/angular-develop ... th-primeng Blog: https://medium.com/@OlegVaraksin

User avatar
Oleg
Expert Member
Posts: 3805
Joined: 02 Oct 2009, 09:41
Location: Germany, Black Forest

06 May 2010, 21:32

PrimeFaces Cookbook (2. edition): http://ova2.github.io/primefaces-cookbook/ Learning Angular UI Development with PrimeNG: https://github.com/ova2/angular-develop ... th-primeng Blog: https://medium.com/@OlegVaraksin

cagatay.civici
Prime
Posts: 18616
Joined: 05 Jan 2009, 00:21
Location: Cybertron
Contact:

09 May 2010, 12:48

Hi Oleg,

As panel can now also contain close and menu icons in addition to toggle, this feature is disabled.

User avatar
Oleg
Expert Member
Posts: 3805
Joined: 02 Oct 2009, 09:41
Location: Germany, Black Forest

10 May 2010, 13:38

cagatay.civici wrote:Hi Oleg,

As panel can now also contain close and menu icons in addition to toggle, this feature is disabled.
I didn't understand why this feature was disabled. I think, we speak about different things. We have a long panel. Our customers don't want to click on a small close icon to collapse the panel and see buttons below. They want to click somewhere on the panel header (don't matter where along header). It's better for usability and simpler than to find the quite close icon.
PrimeFaces Cookbook (2. edition): http://ova2.github.io/primefaces-cookbook/ Learning Angular UI Development with PrimeNG: https://github.com/ova2/angular-develop ... th-primeng Blog: https://medium.com/@OlegVaraksin

drakenra
Posts: 22
Joined: 15 Feb 2010, 20:23

10 May 2010, 17:38

I am glad someone agrees with me :)

Same here: http://primefaces.prime.com.tr/forum/vi ... f=3&t=2005

User avatar
Oleg
Expert Member
Posts: 3805
Joined: 02 Oct 2009, 09:41
Location: Germany, Black Forest

10 May 2010, 17:44

drakenra wrote:I am glad someone agrees with me :)

Same here: http://primefaces.prime.com.tr/forum/vi ... f=3&t=2005
We are yet in pairs :-) At least in pairs.
PrimeFaces Cookbook (2. edition): http://ova2.github.io/primefaces-cookbook/ Learning Angular UI Development with PrimeNG: https://github.com/ova2/angular-develop ... th-primeng Blog: https://medium.com/@OlegVaraksin

cagatay.civici
Prime
Posts: 18616
Joined: 05 Jan 2009, 00:21
Location: Cybertron
Contact:

10 May 2010, 23:04

Ok then feel free to create an issue ticket, we'll try to look into it as time permits. Can't say it has a priority though as we are pretty booked due to demands of enterprise clients which is good though :)

User avatar
Oleg
Expert Member
Posts: 3805
Joined: 02 Oct 2009, 09:41
Location: Germany, Black Forest

11 May 2010, 09:43

cagatay.civici wrote:Ok then feel free to create an issue ticket, we'll try to look into it as time permits. Can't say it has a priority though as we are pretty booked due to demands of enterprise clients which is good though :)
Hello Cagatay,

You should reactivate this issue http://code.google.com/p/primefaces/iss ... ail?id=798. :-)

Yes, it doesn't have high priority. My problem is that we have much content and a panel's close icon is not visible at all by reason of scrollbars. I overwritten your PanelRenderer until you fix this issue.
PrimeFaces Cookbook (2. edition): http://ova2.github.io/primefaces-cookbook/ Learning Angular UI Development with PrimeNG: https://github.com/ova2/angular-develop ... th-primeng Blog: https://medium.com/@OlegVaraksin

cody.lerum
Posts: 4
Joined: 28 Sep 2010, 23:20

28 Sep 2010, 23:22

Since the existing issue was still marked as won't fix I've gone ahead and created a new one.

http://code.google.com/p/primefaces/iss ... il?id=1287

Post Reply

Return to “PrimeFaces”

  • Information
  • Who is online

    Users browsing this forum: No registered users and 46 guests