p:confirmDialog on primefaces 2.1RC1

[timotius_pamungkas]

Hi
I'm currently trying primefaces 2.1RC, and it works nice. But just to remind you so that primefaces team won't miss this case:

Code: Select all

<p:commandButton value="Test" action="somePage.jsf">
	<p:confirmDialog message="Give me some confirmation" />
</p:commandButton>

The dialog didn't shown, while on primefaces 2.0.2 this works fine

Thanks
Primefaces = GOOD

[Oleg]

Hi,

p:confirmDialog is a standalone component. Define it outside of p:commandButton.

[timotius_pamungkas]

Well, the code works on primefaces 2.0.2. Shouldn't primefaces 2.1 (even if it's still RC) adopt same concept?

[cagatay.civici]

ConfirmDialog is not backward compatible in 2.1

[timotius_pamungkas]

well then, i guess i have to re-code those confirmDialogs... thanks

[timotius_pamungkas]

I try to re-code my previous 2.0.2 code

Code: Select all

<p:commandButton value="#{resources.global_cancel}" tabIndex="999"
	immediate="true" action="#{sellAdnimalBean.cancelSellAdnimal}" ajax="false">
	<p:confirmDialog message="#{resources_member.member_sell_confirmCancelSellAdnimal}"
		fixedCenter="true" severity="warn"
 yesLabel="#{resources.global_yes}"
		noLabel="#{resources.global_no}" modal="true" close="false" />
</p:commandButton>

to this

Code: Select all

<p:commandButton value="#{resources.global_cancel}" tabIndex="999"
	immediate="true" onclick="confirmation.show()" /> 
	
<p:confirmDialog widgetVar="confirmation"								message="#{resources_member.member_sell_confirmCancelSellAdnimal}"
	fixedCenter="true" severity="alert" modal="true">
	<p:commandButton value="#{resources.global_yes}" ajax="false"
		oncomplete="confirmation.hide()" immediate="true"
		action="#{sellAdnimalBean.cancelSellAdnimal}" />
	<p:commandButton value="#{resources.global_no}"
		onclick="confirmation.hide()" />
</p:confirmDialog>

while the backing bean action:

Code: Select all

	public String cancelSellAdnimal() {
		......

		return "/pages/member/sell_index.jsf";
	}

but it doesn't work. On 1st code (2.0.2), when I click "Yes" button, it will call the code and redirect page to sell_index.jsf, while on 2.1RC1 code, it didn't do anything

Any idea? thank you

[mkuthan]

Have you created an issue in project bug tracker? I would like to track and vote for this bug.

[timotius_pamungkas]

http://code.google.com/p/primefaces/iss ... ail?id=983

thanks

[cagatay.civici]

This is not a bug as dialog is appended to document's body, if you turn on ajax to true, it should work.

We'll look into this limitation with non-ajax submissions.

[cagatay.civici]

To give an update, I've changed dialog not to be appended to the document body, so it is located where it is defined now. You don't need to define a form inside a dialog now, your page description will be same as the generated dom. So it is fixed now, this will be available along with the release or tomorrow's nightly build.