PF4 + DataTable + Lazy + CommandLink == :-(

[jimklo]

Hi,

Using:
- PF4
- JSF 2.2
- JEE7
- Glassfish 4


I've got a DataTable of which I'm using a lazy dataset. This much works fine.

Now if I want to add a button in one of the columns, using either CommandLink or CommandButton - various client events fire, however neither action or actionListener gets fired.

If I remove the lazy dataset everything works fine... Hence I'm really confused...

For the time being... I've not implemented sort/filtering on my Lazy collection as I need the basics working first:

Code: Select all

    @PostConstruct
    public void init() {
        // lazy
        lazyProjects = new LazyDataModel<Project>() {
            @Override
            public List<Project> load(int first, int pageSize, String sortField, SortOrder sortOrder, Map<String, String> filters) {
                List<Project> projects = projectFacade.findRange(first, pageSize);
                setRowCount(projectFacade.count());
                return projects;
            }
        };
        // non-lazy
        projects = projectFacade.findAll();
    }

And here is my DataTable:

Code: Select all

<p:dataTable id="taskTable" value="#{taskListBean.lazyProjects}" lazy="true"
                                     var="item"
                                     paginator="true"
                                     paginatorTemplate="{CurrentPageReport}  {FirstPageLink} {PreviousPageLink} {PageLinks} {NextPageLink} {LastPageLink} {RowsPerPageDropdown}"
                                     currentPageReportTemplate="{startRecord} - {endRecord} of {totalRecords}"
                                     rowsPerPageTemplate="10,100,500,1000,5000" rows="10"

                                     >
/* display columns omitted */

                             <p:column headerText="Action" >
                                <p:commandLink actionListener="#{taskListBean.doEdit(item)}" title="Edit">
                                    <span class="ui-icon ui-icon-pencil">Edit</span>
                                </p:commandLink>

                                <p:commandLink rendered="#{request.isUserInRole('admin')}" action="#{taskListBean.destroy}" title="Delete" >
                                    <span class="ui-icon ui-icon-trash">Delete</span>
                                </p:commandLink>
                            </p:column>

</p:dataTable>

So when I click on the Edit link... nothing happens... it never calls the taskListBean.doEdit(Project project) method.

If the only thing I do is switch the dataTable to use the non-lazy collection:

Code: Select all

<p:dataTable id="taskTable" value="#{taskListBean.projects}" ...

Everything works...

Anyone have any hints as to what might be going wrong?

Thanks,

- JK

[PeeeZnBlack]

Have you already tried, using action instead of actionListener?

[jimklo]

Have you already tried, using action instead of actionListener?

Yep. I've tried a half-dozen different combinations.

To only make things even worse.... now that I'm using the non-lazy collection to back the table until I find a solution to this. Filtering seems to work... but the column that contains my CommandLink, when filter is active the row that the button effects is the one in the same position of the unfiltered data.

[smithh032772]

Code: Select all

                                <p:commandLink actionListener="#{taskListBean.doEdit(item)}" title="Edit">
                                    <span class="ui-icon ui-icon-pencil">Edit</span>
                                </p:commandLink>

                                <p:commandLink rendered="#{request.isUserInRole('admin')}" action="#{taskListBean.destroy}" title="Delete" >
                                    <span class="ui-icon ui-icon-trash">Delete</span>
                                </p:commandLink>

1. what happens when you replace title="Edit" with value="Edit" and remove the <span/> ?

2. can you output something to system.out/err inside of taskListBean.doEdit() ?

3. add update="..." to p:commandLink if you want the page updated after the AJAX request.

4. add oncomplete="alert('button clicked');" to p:commandLink

5. what is the HTML rendered in the browser/client for the p:commandLink ?

[andyba]

Try using commandButton instead of commandLink.

[dobelf]

you can try to add attribute process="@this" on your either commandLink or commandButton.

[echo]

I am dealing with same problem on PF5. Everything is ok when i use non-lazy collection. But in lazy collections actions and action listeners does not work.

Have you already tried, using action instead of actionListener?

Yep. I've tried a half-dozen different combinations.

To only make things even worse.... now that I'm using the non-lazy collection to back the table until I find a solution to this. Filtering seems to work... but the column that contains my CommandLink, when filter is active the row that the button effects is the one in the same position of the unfiltered data.

[Melloware]

I have the same issue and I think it is because PF is not generate the link id's correctly. So if I just do an "update=@form" to update the datatable it generates the links with invalid ids

<a id="frmMain:lnkResults"

But if while on that page I hit F5 and refresh the entire page entirely is generates the links properly with rowids

<a id="frmMain:3:lnkResults"

which the above link is for row 3 of my table and then my action actual works. So its a PF bug.