FontAwesome update to 4.3.0

[srbala]

This is an enhancement request.

I needed to make use of some of the new icons which are part of 4.3.0 release. I have update fork with 4.3 version of FA. I have tested my changes with showcase sample page and my personal project. working good.

Since my change can benefit the community, I have posted pull request to PrimeFaces library and Showcase.


https://github.com/primefaces/primefaces/pull/170
https://github.com/primefaces/showcase/pull/3

Snapshot below based on my local primefaces snapshot and updated fa.xhtml page.


Thank you,
Bala

[srbala]

Building requires updated to pom.xml (pull request 1) https://github.com/primefaces/showcase/pull/1

integrated sources available in my personal repository.
https://github.com/srbala/pf-showcase/tree/integration
https://github.com/srbala/pf-showcase/c ... ntegration

[kukeltje]

PF should imo drop integrating FA by itself and instead include a dependency on the FA. webjar. Then all this is not needed

[srbala]

I disagree ..!.

1. My patch itself just drop in replace and with minor update to URL references. Advantage of font awesome being part of PrimeFaces library is that, when it is enabled, css and fonts are automatically added. Version 4.2 to 4.3, Primefaces applications require no change at all, except the drop in of new PrimeFaces jar file.

2. It is true that webjars provide the compression of library, but every page/template uses it needs to include the library (as below). Yes you could get the library more sooner, every application page requires change for the version number (unless every application developed has a way of configurable variables).

Code: Select all

<link rel='stylesheet' href='webjars/font-awesome/4.3.0/css/font-awesome.min.css'>

[kukeltje]

Now I disagree... I talked about the includig the dependency on the jar... NOT about how PF uses it. Adding a context param can still result in it (the link) automatically being added to pages

[srbala]

Either I misunderstood your point about webjars or we both are discussion two different point of view.

My understanding webjars is that make use of jar files from http://www.webjars.org/classic
using maven

Code: Select all

<dependency>
    <groupId>org.webjars</groupId>
    <artifactId>font-awesome</artifactId>
    <version>4.3.0-1</version>
</dependency>

which requires font awesome css needs to include by programmer.

It is true, if you want to make use of font awesome from PrimeFaces library, it has to be configured from web.xml, but based on config PrimeFaces library determines to include necessary font awesome css file to generated page header.

If a project using font awesome form PrimeFaces library, currently all font awesome 4.2 icons are available. After my pull request font awesome 4.3 icons will be available. there will be zero change in project.

I hope, I have explained the benefit of font awesome is included in PrimeFaces library.

Thanks,
Bala

[srbala]

Pull request has been merged. should be available in 5.3-SNAPSHOT and 5.2.2 release.