Disabled p:commandButton renders invalid XHTML

[vetler]

Hi,

In Primefaces 2.1, when the commandButton component is disabled (with disabled="true", as per the documentation), the XHTML rendered is:

Code: Select all

<button disabled="true" ... />

However, the W3C validator complains about this, and the correct syntax should be:

Code: Select all

<button disabled="disabled" ... />

This is a fairly common mistake, the correct way to write minimized attributes (selected, checked, disabled, etc.) in XHTML is to write them as foo="foo". See 4.5. Attribute Minimization. Is this a known bug? I was unable to find any issue on this in the issue tracker.

I tried setting disabled="disabled", but this did not seem to have the desired effect.

TIA,
Vetle

[Oleg]

Hi,

HTML

<button disabled="disabled" ... />

should work. See http://www.w3schools.com/TAGS/tryit.asp ... n_disabled

JSF

Code: Select all

<p:commandButton disabled="disabled" ... />

doesn't work because disabled attribute is boolean (true / false) and not string.

This is a PF related issue in CommandButtonRenderer.

[cagatay.civici]

Feel free to create an issue ticket about this as an enhancement. Don't think this will cause a bug but sounds good to generate valid markup for sure.

[vetler]

Hi again!

I created a bug a while ago, but it has not been fixed in Primefaces 2.2.1, unfortunately.
http://code.google.com/p/primefaces/iss ... il?id=1217

This isn't a serious issue, of course, but it would be nice if it could be fixed.