DataTable - Cancel edit doesn't always work

[callahan]

In the 2.2.M1 DataTable, cancel edit doesn't always work.

To reproduce:

- Go here: http://www.primefaces.org/showcase/ui/d ... diting.jsf.
- Put any two rows in edit mode.
- Change the manufacturer in both of these rows to a new value.
- Save one of the rows.
- Cancel the edit to the other row. This doesn't work. The new value for the manufacturer is displayed, not the old value.

When a single row is saved, the data from all rows is posted back to the server and updated in the model. Only the data from the row that is being saved should be updated in the model.

[cagatay.civici]

Yes, I'm aware of this issue, data is processed as a whole not row based, something to improve in 2.2.RC1.

[callahan]

Created issue: http://code.google.com/p/primefaces/iss ... il?id=1280

[cagatay.civici]

Cool Harry, thx!

[cagatay.civici]

Should be fixed now.

[callahan]

çok güzel (http://translate.google.de/#tr|en|%C3%A7ok%20g%C3%BCzel)

Wow, the modification required to fix this was amazingly tiny! Here is is in all its glory http://code.google.com/p/primefaces/sou ... ail?r=3570

[cagatay.civici]

Yes, thanks to JSF 2, things are much easier to create.

[bumble.bee]

Thanks for fixing this.

I actually started to like the idea of an edit-all (with save-all / cancel-all). The controls could perhaps be located in the column header or footer as an optional edit-all facet? Maybe a future enhancement?

[callahan]

Hey bumble.bee, you didn't sound too happy about this feature a week or two ago. In actual fact, you were using terrible words to describe it .

[bumble.bee]

I showed the customer a preview last week and they said "hey, I like being able to save all rows at once." I said, "yeah, that's a feature that is totally there on purpose"!

Obviously it wasn't fully implemented though because it didn't close all rows open for editing when you saved and you had to click each row indivdually to open it for editing, etc.

Oh well...