PrimeFaces 6.0 does not cache images on the client side

[Tiny]

Given a <p:dataTable> rendering images in one of the columns.

Code: Select all

<p:dataTable id="dataTable" var="row" value="#{bean}"
             lazy="true"
             skipChildren="true">

    <p:column headerText="Image">
        <p:cellEditor>
            <f:facet name="output">
                <p:graphicImage value="#{imageBean.image}" stream="true" cache="true">
                    <f:param name="id" value="#{row.id}"/>
                    <f:param name="width" value="100"/>
                    <f:param name="height" value="100"/>
                </p:graphicImage>
            </f:facet>

            <f:facet name="input">
                <p:graphicImage value="#{imageBean.image}" stream="true" cache="true">
                    <f:param name="id" value="#{row.id}"/>
                    <f:param name="width" value="100"/>
                    <f:param name="height" value="100"/>
                </p:graphicImage>

                <!-- <p:overlayPanel> here for file upload -->
            </f:facet>
        </p:cellEditor>
    </p:column>

    <p:column headerText="Edit">
        <p:rowEditor/>
    </p:column>
</p:dataTable>

The data table may contain other essential commonly used attributes and columns as and when needed.

When this table is (Ajaxically) updated, all images are fetched from the database (or disk file system, if used) as if they are not cached by the browser at all even though cache is explicitly set to true (which is the default value). This was working well previoulsly with PrimeFaces 5.3 final.

The migration guide states nothing about it but apparently something has been changed about caching <p:graphicImage>.

https://github.com/primefaces/primeface ... tion-Guide

Any suggestion to fix the problem?

In the example above, if the table contains 5 images in 5 rows, for example, the database will be queried 10 times on every single update made to the <p:dataTable> (except inline row editing which defaults to the current row) which should not happen as getting images especially from a database is very costly.

[smithh032772]

In the example above, if the table contains 5 images in 5 rows, for example, the database will be queried 10 times on every single update made to the <p:dataTable> (except inline row editing which defaults to the current row) which should not happen as getting images especially from a database is very costly.

Why JSF calls getters multiple times (see BalusC's answer)

Also, maybe you need to consider writing a Servlet filter for browser caching (see this too)

[kukeltje]

@Howard: did you read it worked with 5.3? And Tiny knows the 'getter being called multiple times' Tiny is avtively answering on Stackoverflow to

[Tiny]

This is an issue in PrimeFaces 6.0 and has been reported on the issue tracker.

https://github.com/primefaces/primefaces/issues/1765