onclick javascript confirm on commandLink

[mSephiroth]

Hello

I am using primefaces 2.2M1 and I im trying to add a javascript confirm dialog on a commandLink in a DataTable with the follow code:

Code: Select all

                                    <p:dataTable value="#{TareaMBean.obtenerTareasDeCurso(curso.cursoActual)}" var="item"
                                                 emptyMessage="No se encontraron tareas en este curso"
                                                 paginator="true" rows="10" >

                                       .....                                       
                                        <p:column>
                                            <f:facet name="header">
                                                <h:outputText value="Eliminar"/>
                                            </f:facet>
                                            <h:commandLink title="Eliminar" action="#{TareaMBean.borrarTarea(item)}"
                                                           onclick="if(confirm('Esta seguro de eliminar esta tarea? Tambien se borraran los trabajos entregados'))return true; else return false;">
                                                <h:graphicImage alt="eliminar" url="/images/delete.gif"/>
                                            </h:commandLink>
                                        </p:column>
                                        <p:column>
                                            <f:facet name="header">
                                                <h:outputText value="Visible"/>
                                            </f:facet>                                            
                                        </p:column>
                                    </p:dataTable>
                                

the confirmdialog is showed but when I confirm the action, it doesnt execute the action. when I set ajax = "false" it works, but with ajax enabled it doesnt works.

May be I missing something.

Thanx for help

[timotius_pamungkas]

instead of using standard js confirm(), primefaces has a confimDialog component for this purpose (which is also better look and feel). Find how to use it here: http://www.primefaces.org/showcase/ui/confirmDialog.jsf

[mSephiroth]

Hi, I have tested the p:confirmDIalog, but in the case of a table, I create a confirmDialog for each row, is that afecting the performance of the application?

[cagatay.civici]

You can use one confirmDialog for all rows.

[timotius_pamungkas]

as optimus says, one confirm dialog is enough. If you need to pass id to be deleted, you can do so by adding attribute "selection" of datatable, or using f:attribute/f:setPropertyActionListener to pass the desired value

[mSephiroth]

oh ya, I'll test

thanks

[mSephiroth]

Hi, I have tested the solutions you suggested and it works, but when I do an ajax update from de confirmdialog, sometimes it works, and sometimes didnt.

I generate tables in a eachfor tag and then use a confirmdialog for confirm a remove action for a row in each table.

any idea?