p:calendar calls selectListener method every postback

[kwinchester]

I noticed that the p:calendar tag was calling my selectListener method even when I had not changed the date at the client. Looking at the code, I see:

Code: Select all

if(calendar.getSelectListener() != null) {
    calendar.queueEvent(new DateSelectEvent(calendar, convertedValue));
}

There does not seem to be any dependence on whether or not the value was changed, unless I am reading things wrong. In the p:autoComplete tag, which also has a selectListener, I see:

Code: Select all

if (facesContext.getExternalContext().getRequestParameterMap().containsKey(autoComplete.getClientId(facesContext) + "_ajaxSelect")) {
    SelectEvent selectEvent = new SelectEvent(autoComplete, value);
    selectEvent.setPhaseId(PhaseId.INVOKE_APPLICATION);
    autoComplete.queueEvent(selectEvent);
}

which seems to rely on a special request parameter from the client to indicate that a selection was made.

What is the intended behaviour of the selectListener for the p:calendar tag?

[cagatay.civici]

Can you replicate it at showcase?

[kwinchester]

Unfortunately no, the only showcase example with a selectListener is this one:

http://www.primefaces.org/showcase/ui/calendarAjax.jsf

And it does not have any way to submit the form other than by selecting a date. If you add a p:commandButton to that form, then I believe clicking that button will result in the selectListener being invoked, even if no date selection was made. Is it possible for you to try that out?

[cagatay.civici]

Noted down, will check tomorrow.

[cagatay.civici]

Fixed now;

http://code.google.com/p/primefaces/iss ... il?id=1737

Thanks for your feedback.