Font-Awesome bug? Two icons on menu items inside menu bar

UI Components for JSF
Post Reply
matsa
Posts: 62
Joined: 12 Sep 2011, 11:14

16 May 2015, 13:38

When I enabled FA in my web.xml and started replacing jquery icons with fa icons I get odd behaviour in menu bars.
This problem does not occur with command buttons, buttons, etc. outside menu bars. I've tried several base themes, including metroui.

In my menu bar the menu items tend to look like this:

Code: Select all

<li class="ui-menuitem ui-widget ui-corner-all" role="menuitem"><a tabindex="-1" class="ui-menuitem-link ui-corner-all" href="/thewall/faq.xhtml"><span class="ui-menuitem-icon ui-icon fa fa-question"></span><span class="ui-menuitem-text">Hjelp</span></a></li>
Specifically, the icon span element has an extra ui-icon class.

My markup is

Code: Select all

<p:menuitem icon="fa fa-question" outcome="faq" value="Hjelp"/>
The same thing happens for p:submenu elements.

I've tested both 5.1.17 and 5.2.1.
Tomcat 9.0
JSF 2.2 (Mojarra 2.2.15)
PrimeFaces 10.0.5

User avatar
sudheer
PrimeFaces Core Developer
Posts: 4345
Joined: 16 Oct 2011, 19:19
Location: Singapore

24 Jun 2015, 08:50

Are you able to replicate on showcase example.Is it specific to menuBar or any menu component?
Author,Speaker
https://twitter.com/sudheerjonna
Github: https://github.com/sudheerj
Website http://sudheerjonna.com/

___________________
Sudheer Jonna

User avatar
sudheer
PrimeFaces Core Developer
Posts: 4345
Joined: 16 Oct 2011, 19:19
Location: Singapore

28 Jun 2015, 10:22

I can't replicate the issue on menubar component When tried on metro-ui theme.There is only one icon visible in the screen.
Author,Speaker
https://twitter.com/sudheerjonna
Github: https://github.com/sudheerj
Website http://sudheerjonna.com/

___________________
Sudheer Jonna

matsa
Posts: 62
Joined: 12 Sep 2011, 11:14

29 Jun 2015, 08:57

Thanks for giving this your attention! I'm going to look further into it today and see if I can discover something.

EDIT: Btw, where can I download the showcase so that I can experiment on that?
Tomcat 9.0
JSF 2.2 (Mojarra 2.2.15)
PrimeFaces 10.0.5

User avatar
sudheer
PrimeFaces Core Developer
Posts: 4345
Joined: 16 Oct 2011, 19:19
Location: Singapore

29 Jun 2015, 11:27

Author,Speaker
https://twitter.com/sudheerjonna
Github: https://github.com/sudheerj
Website http://sudheerjonna.com/

___________________
Sudheer Jonna

matsa
Posts: 62
Joined: 12 Sep 2011, 11:14

29 Jun 2015, 13:36

I just upgraded from 5.1.17 to 5.1.20 and the problem vanished! I'm uncertain as to why but I thought I'd mention it quickly.
Tomcat 9.0
JSF 2.2 (Mojarra 2.2.15)
PrimeFaces 10.0.5

User avatar
sudheer
PrimeFaces Core Developer
Posts: 4345
Joined: 16 Oct 2011, 19:19
Location: Singapore

13 Jul 2015, 20:25

Thanks for the confirmation.It may be specific to particular elite release.Works properly on latest versions.
Author,Speaker
https://twitter.com/sudheerjonna
Github: https://github.com/sudheerj
Website http://sudheerjonna.com/

___________________
Sudheer Jonna

Post Reply

Return to “PrimeFaces”

  • Information
  • Who is online

    Users browsing this forum: No registered users and 23 guests