Page 1 of 1
Asymmetric and cropped focus frame in Firefox
Posted: 21 Apr 2022, 12:38
by tetzla
The focus frame of some controls is slightly asymmetric and cropped in Firefox (see
https://www.primefaces.org/diamond/input.xhtml > Radiobutton). With the following change the flaw can be avoided:
Code: Select all
//current code (light)
$focusShadow: 0 0 0 0.2rem $focusOutlineColor;
//suggested code (light)
$focusShadow: 0 0 0 0.25rem $focusOutlineColor; //or 0.125rem
In dim/dark scheme 1px (insteadof 0.2rem) is used. This also looks a little bit strange in Firefox.
In Edge and Chrome there are no such problems.
Regards tetzla
Re: Asymmetric and cropped focus frame in Firefox
Posted: 27 Apr 2022, 12:58
by mert.sincan
I think this seems to be an issue with firefox.
https://stackoverflow.com/questions/247 ... and-border
Does 0.22rem work fine?
Re: Asymmetric and cropped focus frame in Firefox
Posted: 28 Apr 2022, 09:33
by tetzla
Hello,
.22rem works also fine.
Regards tetzla
Re: Asymmetric and cropped focus frame in Firefox
Posted: 28 Apr 2022, 09:55
by mert.sincan
Hi,
Thanks a lot for the update! Fixed for v3.1.1. I plan to release it next week.
Best Regards,
Re: Asymmetric and cropped focus frame in Firefox
Posted: 10 May 2022, 10:02
by tetzla
The last week has passed. However, version 3.1.1 was not delivered. What is the updated schedule?
Re: Asymmetric and cropped focus frame in Firefox
Posted: 13 May 2022, 10:51
by mert.sincan
So sorry for the delay. I'm adding some features to the designer. Today I'll release all Premium Layouts.
Best Regards,
Re: Asymmetric and cropped focus frame in Firefox
Posted: 30 May 2022, 10:25
by miedrl
Hi,
the variable of $focusShadow has been adapted, but shouldn't this also be done for other focus shadow variables? I found the following variables which could be adapted the same way (I'm not sure with $inputListItemFocusShadow though).
$inputListItemFocusShadow
$secondaryButtonFocusShadow
$infoButtonFocusShadow
$successButtonFocusShadow
$warningButtonFocusShadow
$helpButtonFocusShadow
$dangerButtonFocusShadow
Regards, miedrl
Re: Asymmetric and cropped focus frame in Firefox
Posted: 31 May 2022, 13:40
by mert.sincan
Hi,
Do you have the same issue with the focus variable above?
Re: Asymmetric and cropped focus frame in Firefox
Posted: 07 Dec 2022, 13:07
by miedrl
Hello,
will the variables I listed above also be adapted so the focus shadow radius is the same (0.22rem)?
Regards
Re: Asymmetric and cropped focus frame in Firefox
Posted: 14 Dec 2022, 12:46
by mert.sincan
For now, no. Maybe, you can add a custom variable for it in your app. I'll talk Designer team about it again.
Best Regards,