New slf4j-api dependency

Community Driven Extensions Project
Post Reply
rbetjes
Posts: 12
Joined: 24 Nov 2016, 16:34

21 Mar 2023, 18:26

It seems that 12.0.4 introduced a dependency on slf4j-api.
I cannot seem to find any mention of this new dependency. Did I miss something?
12.0.3 can be used without it.

It is used in the new Session component to output 2 debug log lines. Perhaps it would be better to change this to use java.util.logging.Logger, or to remove the debug logging alltogether?

To use 12.0.5 (or 12.0.4) we could include slf4j in the project like:

Code: Select all

        <dependency>
            <groupId>org.slf4j</groupId>
            <artifactId>slf4j-api</artifactId>
            <version>1.7.25</version>
        </dependency>
For now I changed the Session component code to use java.util.logging.Logger to avoid the added dependency.

Melloware
Posts: 3716
Joined: 22 Apr 2013, 15:48

21 Mar 2023, 21:24

Ahh can you please open a ticket. I don't think we should have this new dependency.

https://github.com/primefaces-extension ... ons/issues

I should have caught that in the code review.
PrimeFaces Developer | PrimeFaces Extensions Developer
GitHub Profile: https://github.com/melloware
PrimeFaces Elite 13.0.0 / PF Extensions 13.0.0
PrimeReact 9.6.1

Melloware
Posts: 3716
Joined: 22 Apr 2013, 15:48

21 Mar 2023, 22:02

PrimeFaces Developer | PrimeFaces Extensions Developer
GitHub Profile: https://github.com/melloware
PrimeFaces Elite 13.0.0 / PF Extensions 13.0.0
PrimeReact 9.6.1

rbetjes
Posts: 12
Joined: 24 Nov 2016, 16:34

22 Mar 2023, 09:57

That was quick 👍.
Removed the debug log I see. Looks good.
Thanks.

DonaldPearson
Posts: 1
Joined: 10 Apr 2023, 12:18

10 Apr 2023, 12:20

It appears that the version 12.0.4 of the component introduced a new dependency on slf4j-api. This may not have been explicitly mentioned in the documentation or release notes for the component.It's understandable to be concerned about the added dependency, especially if it wasn't mentioned or documented. If you are uncomfortable with this dependency, you may want to consider either removing the debug logging altogether or modifying the Session component code to use java.util.logging.Logger instead.
Alternatively, if you do want to continue using version 12.0.4 (or 12.0.5) of the component and include the slf4j-api dependency, you can add it to your project's dependencies as you mentioned in your message:
php
Copy code
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>1.7.25</version>
</dependency>
Ultimately, the best course of action will depend on your specific needs and requirements for the project.

Melloware
Posts: 3716
Joined: 22 Apr 2013, 15:48

11 Apr 2023, 14:22

It has already been removed and 12.0.6 is out.
PrimeFaces Developer | PrimeFaces Extensions Developer
GitHub Profile: https://github.com/melloware
PrimeFaces Elite 13.0.0 / PF Extensions 13.0.0
PrimeReact 9.6.1

Post Reply

Return to “Extensions”

  • Information
  • Who is online

    Users browsing this forum: No registered users and 8 guests