Sheet: needs filterMatchMode

Community Driven Extensions Project
Post Reply
rbetjes
Posts: 7
Joined: 24 Nov 2016, 16:34

11 Oct 2018, 17:33

So I have a sheet with some columns that are of the dropdown type with selectItems created from a list of POJO's.
That means that the selectItems value will be (in my case) an int. This poses a problem with the filter as that is implemented with only a "contains" rule.
So filtering on the value 1 will return 1's but also 10's, 11's, and so on.

I was a bit suprised that no one needed different rules up until now.

I have already implemented a filterMatchMode attribute and it does the job. Possible math rules are: "startsWith", "endsWith", "contains" and "exact".
Would you like a PR for that?

User avatar
Melloware
Posts: 765
Joined: 22 Apr 2013, 15:48

11 Oct 2018, 18:28

Yes please. No one happens to have asked for this yet.
PrimeFaces Extensions Developer
GitHub Profile: https://github.com/melloware
PrimeFaces Elite 6.2.10 / PF Extensions 6.2.9


User avatar
Melloware
Posts: 765
Joined: 22 Apr 2013, 15:48

11 Oct 2018, 20:14

Nice sent you one minor code review comment to add to your PR and it will be good.
PrimeFaces Extensions Developer
GitHub Profile: https://github.com/melloware
PrimeFaces Elite 6.2.10 / PF Extensions 6.2.9

Post Reply

Return to “Extensions”

  • Information
  • Who is online

    Users browsing this forum: No registered users and 2 guests