mozilla is not defined with angular RC4

Locked
mbrancaleoni
Posts: 20
Joined: 10 Jun 2016, 11:48

30 Jun 2016, 23:36

another angular2 release, RC4, another breaking change.

seems that $.browser is no more present (why?) so layout.js fails (line 18).

commenting out the if " if(this.mobile && $.browser.mozilla) {..." seems to fix the issue.

but cannot get why happens only with RC4

mert.sincan
Posts: 5281
Joined: 29 Jun 2013, 12:38

11 Jul 2016, 15:06

Can you please try our new layout version? and Do you get an error with our live demo? http://www.primefaces.org/modena-primeng/

mbrancaleoni
Posts: 20
Joined: 10 Jun 2016, 11:48

11 Jul 2016, 15:32

yes, tried with latest 1.0.2

and yes, happens also on your demo, just use the device selector of chrome to simulate any mobile device.

if you're in desktop mode, it won't happen.

mert.sincan
Posts: 5281
Joined: 29 Jun 2013, 12:38

15 Jul 2016, 13:06

Please add this fix;

Code: Select all

init: function() {

     ...
   //remove transform on Firefox Mobile 
   if(this.mobile && ($.browser && $.browser.mozilla)) {
       this.mobileMenuButton.addClass('no-transform');
       this.menu.addClass('no-transform');
  }
  ...
},

...
I'll add this fix into next release.


mbrancaleoni
Posts: 20
Joined: 10 Jun 2016, 11:48

18 Jul 2016, 22:03

yup it works

mert.sincan
Posts: 5281
Joined: 29 Jun 2013, 12:38

21 Jul 2016, 15:13

Thanks for the update!

Locked

Return to “Modena”

  • Information
  • Who is online

    Users browsing this forum: No registered users and 4 guests