Page 1 of 1

mozilla is not defined with angular RC4

Posted: 30 Jun 2016, 23:36
by mbrancaleoni
another angular2 release, RC4, another breaking change.

seems that $.browser is no more present (why?) so layout.js fails (line 18).

commenting out the if " if(this.mobile && $.browser.mozilla) {..." seems to fix the issue.

but cannot get why happens only with RC4

Re: mozilla is not defined with angular RC4

Posted: 11 Jul 2016, 15:06
by mert.sincan
Can you please try our new layout version? and Do you get an error with our live demo? http://www.primefaces.org/modena-primeng/

Re: mozilla is not defined with angular RC4

Posted: 11 Jul 2016, 15:32
by mbrancaleoni
yes, tried with latest 1.0.2

and yes, happens also on your demo, just use the device selector of chrome to simulate any mobile device.

if you're in desktop mode, it won't happen.

Re: mozilla is not defined with angular RC4

Posted: 15 Jul 2016, 13:06
by mert.sincan
Please add this fix;

Code: Select all

init: function() {

     ...
   //remove transform on Firefox Mobile 
   if(this.mobile && ($.browser && $.browser.mozilla)) {
       this.mobileMenuButton.addClass('no-transform');
       this.menu.addClass('no-transform');
  }
  ...
},

...
I'll add this fix into next release.

Re: mozilla is not defined with angular RC4

Posted: 15 Jul 2016, 13:15
by mert.sincan

Re: mozilla is not defined with angular RC4

Posted: 18 Jul 2016, 22:03
by mbrancaleoni
yup it works

Re: mozilla is not defined with angular RC4

Posted: 21 Jul 2016, 15:13
by mert.sincan
Thanks for the update!