Adding TS Files in Release 0.8.0 killed my project

UI Components for Angular
Post Reply
CC84
Posts: 69
Joined: 11 Mar 2016, 09:32

21 Mar 2016, 09:58

As described here http://forum.primefaces.org/viewtopic.php?f=35&t=44850
you have added the TS Files to Release. Now i'm unable to build my project.
At first i have disabled: Allow implicit any types. In PrimeNG are alot of them, so i had to enable this. Further i'm missing lots of Typescript definitions. (DatePicker from JQueryUI, Chart, lots of PUI stuff....)
Don't wanted to search all this stuff, so as a workaround i just deleted all the TS Files from node_modules.

cagatay.civici
Prime
Posts: 18616
Joined: 05 Jan 2009, 00:21
Location: Cybertron
Contact:

21 Mar 2016, 10:00

Yes, we've seen that as well. Current solution is adding the new d.ts files to your typings.json;

http://www.primefaces.org/primeng/#/setup

Code: Select all

{
  "ambientDependencies": {
    "chart": "github:DefinitelyTyped/DefinitelyTyped/chartjs/chart.d.ts#9f28e020a04c0b726a5e21c5cf0d1fc91f0de626",
    "es6-shim": "github:DefinitelyTyped/DefinitelyTyped/es6-shim/es6-shim.d.ts#6697d6f7dadbf5773cb40ecda35a76027e0783b2",
    "jquery": "github:DefinitelyTyped/DefinitelyTyped/jquery/jquery.d.ts#470954c4f427e0805a2d633636a7c6aa7170def8",
    "jqueryui": "github:DefinitelyTyped/DefinitelyTyped/jqueryui/jqueryui.d.ts#a3a5cd5554dc2c0ff8955d1db0673879af3095bc",
    "fullcalendar": "github:DefinitelyTyped/DefinitelyTyped/fullCalendar/fullCalendar.d.ts#4de74cb527395c13ba20b438c3a7a419ad931f1c",
    "moment": "github:DefinitelyTyped/DefinitelyTyped/moment/moment-node.d.ts#1be6a281906e5cd179a97c86bd58ebf9cdc9c6a5",
    "primeui": "github:primefaces/primeng/showcase/resources/primeui/primeui.d.ts#46498df6858178405589436d557ec50ba2b431ac"
  }
}
Or should we remove *.ts files and do 0.8.1? Running "tsc" command compiles ts files under node_modules as well causing this.

CC84
Posts: 69
Joined: 11 Mar 2016, 09:32

21 Mar 2016, 10:11

There was a reason for adding TS Files, so removing them can't be the solution.
I'm currently not using Webpack, but i want to in future, so they have to be in there.

Best would be to correct the "implicit any" errors (easiest way, simply add an :any behind them, better add the correct type, where possible). The missing TypeDefinitions is a different problem. I'm working with Visual Studio. And there is no native support for typings.json. I'll have to add the typings by hand. Will do this in future. For now i'll keep the ts files deleted.

cagatay.civici
Prime
Posts: 18616
Joined: 05 Jan 2009, 00:21
Location: Cybertron
Contact:

21 Mar 2016, 10:27

We don't have much webpack experience yet so still not sure *.ts files are necessary, theoretically they shouldn't be. We'll do a webpack quickstart for primeng soon and will work on it that time.

We've done a 0.8.1 just now that doesn't have the ts files so no change is required in your project, like adding typings or removing ts files.

Post Reply

Return to “PrimeNG”

  • Information
  • Who is online

    Users browsing this forum: No registered users and 12 guests