Some build improvements ideas

[jsoft]

• the pom generated for the theme jar contains a lot of un-needed dependencies (openwebbeans, geronimo, poi, openpdf...). I would mark them as provided if using the distribute profile.
• maven-assembly-plugin and maven-shade-plugin: in the executions they change the finalName but not the artifactId: is that correct? (in the old version the artifactId for the theme was apollo-theme-xxx while now it's only apollo-xxx)
• SASS: I added this plugin to the pom so there's no need to launch it from the command line:

  Code: Select all

  <plugin>
  	<groupId>io.github.cleydyr</groupId>
  	<artifactId>dart-sass-maven-plugin</artifactId>
  	<version>0.1.1</version>
  	<executions>
  		<execution>
  			<goals>
  				<goal>compile-sass</goal>
  			</goals>
  		</execution>
  	</executions>
  	<configuration>
  		<inputFolder>${basedir}/src/main/webapp/resources/</inputFolder>
  		<outputFolder>${basedir}/src/main/webapp/resources/</outputFolder>
  		<noSourceMap>true</noSourceMap>
  	</configuration>
  </plugin>

• src/assemble/theme.xml : I replaced all the theme fileSets with this one:

  Code: Select all

  <fileSet>
  	<directory>${basedir}/src/main/webapp/resources</directory>
  	<outputDirectory>/META-INF/resources</outputDirectory>
  	<includes>
  		<include>*/theme.css</include>
  	</includes>
  </fileSet>

  this way, if I add a custom theme, it's automatically included in the jar

[jsoft]

also, the jakarta version of theme has a dependency to the "standard" (javax) version of primefaces - which causes deploy errors if it's not excluded

[mert.sincan]

Hi,

the pom generated for the theme jar contains a lot of un-needed dependencies (openwebbeans, geronimo, poi, openpdf...). I would mark them as provided if using the distribute profile.

- Yes, this improvement can be made. Nice feedback!

maven-assembly-plugin and maven-shade-plugin: in the executions they change the finalName but not the artifactId: is that correct? (in the old version the artifactId for the theme was apollo-theme-xxx while now it's only apollo-xxx)

- No, please see our final name;

Code: Select all

<finalName>${project.name}-layout-${project.version}</finalName>

SASS: I added this plugin to the pom so there's no need to launch it from the command line:

- This is completely optional. Especially in the development phase, such plugins slow us down and the users. In addition, the plugins need to constantly update themselves according to the new features of Sass. Therefore, being dependent on such a plugin limits us most of the time.

src/assemble/theme.xml : I replaced all the theme fileSets with this one:

- Nice feedback! We can update it.

Best Regards,