- the pom generated for the theme jar contains a lot of un-needed dependencies (openwebbeans, geronimo, poi, openpdf...). I would mark them as provided if using the distribute profile.
- maven-assembly-plugin and maven-shade-plugin: in the executions they change the finalName but not the artifactId: is that correct? (in the old version the artifactId for the theme was apollo-theme-xxx while now it's only apollo-xxx)
- SASS: I added this plugin to the pom so there's no need to launch it from the command line:
Code: Select all
<plugin> <groupId>io.github.cleydyr</groupId> <artifactId>dart-sass-maven-plugin</artifactId> <version>0.1.1</version> <executions> <execution> <goals> <goal>compile-sass</goal> </goals> </execution> </executions> <configuration> <inputFolder>${basedir}/src/main/webapp/resources/</inputFolder> <outputFolder>${basedir}/src/main/webapp/resources/</outputFolder> <noSourceMap>true</noSourceMap> </configuration> </plugin>
- src/assemble/theme.xml : I replaced all the theme fileSets with this one:
this way, if I add a custom theme, it's automatically included in the jar
Code: Select all
<fileSet> <directory>${basedir}/src/main/webapp/resources</directory> <outputDirectory>/META-INF/resources</outputDirectory> <includes> <include>*/theme.css</include> </includes> </fileSet>
Some build improvements ideas
Forum rules
Please note that response time for technical support is within 3-5 business days.
Please note that response time for technical support is within 3-5 business days.
-
- Posts: 5281
- Joined: 29 Jun 2013, 12:38
Hi,
Best Regards,
- Yes, this improvement can be made. Nice feedback!the pom generated for the theme jar contains a lot of un-needed dependencies (openwebbeans, geronimo, poi, openpdf...). I would mark them as provided if using the distribute profile.
- No, please see our final name;maven-assembly-plugin and maven-shade-plugin: in the executions they change the finalName but not the artifactId: is that correct? (in the old version the artifactId for the theme was apollo-theme-xxx while now it's only apollo-xxx)
Code: Select all
<finalName>${project.name}-layout-${project.version}</finalName>
- This is completely optional. Especially in the development phase, such plugins slow us down and the users. In addition, the plugins need to constantly update themselves according to the new features of Sass. Therefore, being dependent on such a plugin limits us most of the time.SASS: I added this plugin to the pom so there's no need to launch it from the command line:
- Nice feedback! We can update it.src/assemble/theme.xml : I replaced all the theme fileSets with this one:
Best Regards,
Github Profile: https://github.com/mertsincan
-
- Information
-
Who is online
Users browsing this forum: No registered users and 1 guest