Ultima and ng lint

[NGAllie]

Hi,

I want to start using the ng lint tool provided by Angular-cli to easily validate that our code is compliant with the best practices documented in Angular style guide. We are keeping not only the Ultima app component and menu related components, but also the demo pages (that we have moved in a separate module), in our application during development so that it would be fast and easy to access the samples.

When we run ng lint in our application, we are getting errors coming from the Ultima components and we have to filter them in order to find what we have to change in our application. We could also change the code provided with the Ultima template, but we will have to redo this process every time the template is upgraded.

It would sure be useful if you could clean the code with ng lint (default configurations) before you release new versions of Ultima. Most of the errors reported are easy to change (missing or trailing white spaces, using const instead of let, etc.). You can also install the TSLint extension in VsCode to help you fix most of the errors. There are also a few changes involving renaming components or components' selector.

Thanks

[DarthMaul]

Hi,

Thanks for the suggestion we will discuss it with my colleagues and get back to you.

[NGAllie]

Thanks,

For your information, I have tried "ng lint --fix" with the Ultima 2.1.0 template project and I got 473 errors automatically fixed by the linter. The template still works after this clean up so it looks safe to use based on my first tests. That leaves around 100 "errors" to fix in the template with most being easy to fix.

[DarthMaul]

Thanks for the additional information. We discussed this and decided to fix this for our further releases.

[NGAllie]

Great! Thank you very much!

[DarthMaul]

We will inform you from here after this fix.

[Aorewen]

Thanks guys !