Suggestion regarding code style

Post Reply
cito
Posts: 8
Joined: 12 Aug 2017, 13:43

18 Aug 2017, 14:58

When looking into the Ultima template I noticed that code styles are not applied very well - my linters for TypeScript and Sass complain a lot.

For the next version, please consider linting the ts and scss files (see Sass guidelines and stylelint-config-sass-guidelines for instance), also consider adding comments to the .scss files and adding .stylelintrc and tslint.json files that match the used code style. The template will then be much easier to work with. Also, linting not only helps to get a more consistent and clean code style, but also detects typos and other subtle erros. For instance, one .scss file has "font-weight: 48px;" which is detected as an error by stylelint.

merve7
Posts: 66
Joined: 12 Sep 2017, 10:44

12 Sep 2017, 15:14

Thanks, we will consider this suggestion.

svr
Posts: 4
Joined: 03 Jan 2017, 12:32

15 Sep 2017, 12:12

We have the same request. We're using the following tslint config: https://github.com/ng-seed/angular-tslint-rules, but it fails on the Ultima Code.

Post Reply
  • Information
  • Who is online

    Users browsing this forum: No registered users and 1 guest