Bug/improvement on Ultima menu

[Darnoj]

Hello,

A bug/improvement detected on the default menu of UItima :
Incorrect behaviour if the route changes from a page link or from URL update.

How to reproduce :
1/ Go on : https://www.primefaces.org/ultima-ng/#/
=> nothing selected in the menu

2/ Click on the menu item "Documentation"
=> route change to : https://www.primefaces.org/ultima-ng/#/documentation
=> the documentation page is displayed
=> menu item "Documentation" is selected

3/ Update the URL to : https://www.primefaces.org/ultima-ng/#/documentation
=> the utils page is displayed
=> menu item "Documentation" is still selected
=> menu item "Utils" is not selected

I don't know the version number deployed in the example but in our project we have the previous menu selected but the current route is also correctly selected.

Any help to apply a temporary fix would be appreciated

[cagatay.civici]

I couldn't replicate the issue, can you? The live showcase is now on PrimeNG 5 by the way so it is updated.

[Darnoj]

The update to v5 changed a bit but there is still odd behaviours in red below:

How to reproduce on the current liveshow:
1/ Go on : https://www.primefaces.org/ultima-ng
=> menu item "Dashboard is "half selected" : icon + text in purple but no grey background

2/ Click on the menu item "Components" then on the submenu item "Data"
=> the data page is displayed
=> menu item "Components" is selected : icon + text in purple and grey background
=> submenu item "Data" is selected : icon + text in purple and grey background

3/ Click on the menu item "Documentation"
=> route changes to : https://www.primefaces.org/ultima-ng/#/documentation
=> the documentation page is displayed
=> menu item "Documentation" is selected : icon + text in purple and grey background

4/ Click on the menu item "Components" to display the submenu items
=> the submenu item "Data" is still selected (icon + text in purple and grey background)
=> the grey background of the menu item "Components" is removed

5/ Click on the menu item "Documentation" again
=> menu item "Documentation" is selected : icon + text in purple and grey background

6/ Manually update the URL to : https://www.primefaces.org/ultima-ng/#/utils
=> the utils page is displayed
=> menu item "Documentation" is still selected : icon + text in purple and no grey background
=> menu item "Utils" is "half selected" : icon + text in purple but no grey background

[cagatay.civici]

Half selected is actually means selected by router link using active router link, you can customize it. We wanted to differentiate it, the ones selected by user between the current route.

[Darnoj]

Ok about that it concerns the grey background behaviour only.
I updated the test case accordingly with the remaining issues :

How to reproduce on the current liveshow:
1/ Go on : https://www.primefaces.org/ultima-ng
=> menu item "Dashboard is selected (route selection)

2/ Click on the menu item "Components" then on the submenu item "Data"
=> the data page is displayed
=> menu item "Components" is selected
=> submenu item "Data" is selected (user and route selection)

3/ Click on the menu item "Documentation"
=> route changes to : https://www.primefaces.org/ultima-ng/#/documentation
=> the documentation page is displayed
=> menu item "Documentation" is selected (user and route selection)

4/ Click on the menu item "Components" to display the submenu items
=> the submenu item "Data" is still selected (user and route selection)

5/ Click on the menu item "Documentation" again
=> menu item "Documentation" is selected (user and route selection)

6/ Manually update the URL to : https://www.primefaces.org/ultima-ng/#/utils
=> the utils page is displayed
=> menu item "Documentation" is selected (user selection and route selection)
=> menu item "Utils" is selected (route selection only)