Colors on table headers removed in version 2?

Forum rules
Please note that response time for technical support is within 3-5 business days.
User avatar
bjorntj
Posts: 277
Joined: 30 Jul 2010, 10:46

23 May 2017, 09:07

Any particular reasons? (it looks a bit more lively using colors..)
What's the best way to get it back?


Regards,

BTJ
PrimeFaces 11.x | PrimeVue 3.x | Spring Boot 2.7.x | Undertow | Mojarra 2.3.x
Mac OS, Firefox and Chromium

mert.sincan
Posts: 5281
Joined: 29 Jun 2013, 12:38

23 May 2017, 11:32

I couldn't replicate it. Could you please attach screenshots for us to replicate?

User avatar
bjorntj
Posts: 277
Joined: 30 Jul 2010, 10:46

23 May 2017, 11:50

Well, there is a color but before it used the same color as the topbar (I think).
The color now is really bright and very hard too see..

btw, you see the same in your live theme preview page.
Last edited by bjorntj on 23 May 2017, 22:23, edited 2 times in total.
PrimeFaces 11.x | PrimeVue 3.x | Spring Boot 2.7.x | Undertow | Mojarra 2.3.x
Mac OS, Firefox and Chromium

User avatar
bjorntj
Posts: 277
Joined: 30 Jul 2010, 10:46

23 May 2017, 14:00

Also, I have links in table cells, they no longer have any color...

Edit: this I have "fixed" but just wondered is this was by design or not?
PrimeFaces 11.x | PrimeVue 3.x | Spring Boot 2.7.x | Undertow | Mojarra 2.3.x
Mac OS, Firefox and Chromium

mert.sincan
Posts: 5281
Joined: 29 Jun 2013, 12:38

24 May 2017, 08:45

Well, there is a color but before it used the same color as the topbar (I think).
The color now is really bright and very hard too see..
- Yes, it is by design. You can use the following variable to change background color of header;
in _variables.scss;

Code: Select all

...
$headerBgColor: YOUR_COLOR_CODE;
...
Also, I have links in table cells, they no longer have any color...
- Could you please attach a screenshot for us?

User avatar
bjorntj
Posts: 277
Joined: 30 Jul 2010, 10:46

24 May 2017, 18:45

Why this decision to "remove" the color? I am really curious about the thoughts behind it, is it a trend? does it make the table easier to read? or? :)

Here is a screnshot
Image
But I see now that when I look closely, I think I can see difference between the links and just the texts. (maybe it's because I am red-green colorblind). I was just expecting the blue colors I (and I think many others) are used to, to mark text as links..
(btw, the "blueish" text you see in the screenshot are not links, just ordinary text with that color..)

BTJ
PrimeFaces 11.x | PrimeVue 3.x | Spring Boot 2.7.x | Undertow | Mojarra 2.3.x
Mac OS, Firefox and Chromium

User avatar
w00f
Posts: 307
Joined: 27 Apr 2016, 13:27
Contact:

24 May 2017, 22:06

bjorntj wrote:
24 May 2017, 18:45
Why this decision to "remove" the color? I am really curious about the thoughts behind it, is it a trend? does it make the table easier to read? or? :)

Here is a screnshot
Image
But I see now that when I look closely, I think I can see difference between the links and just the texts. (maybe it's because I am red-green colorblind). I was just expecting the blue colors I (and I think many others) are used to, to mark text as links..
(btw, the "blueish" text you see in the screenshot are not links, just ordinary text with that color..)

BTJ
I can explain the reason behind this decision. It's not about a new design trend or making table's more readable. Of course we always want more readable tables but making this change doesn't make tables less readable -imho-

We wanted to add layout color options to Verona so that it has more customization options for all kinds of user groups. However, changing panel backgrounds according to layout preferences is not possible because layout and theme has different SCSS files. Making the panel background appropriate for all layout options was the best option we had.

For such cases like yours, it's always possible and encouraged to change colors as you want with SCSS variables. :)

User avatar
bjorntj
Posts: 277
Joined: 30 Jul 2010, 10:46

25 May 2017, 13:35

Ok, thx.. :)
PrimeFaces 11.x | PrimeVue 3.x | Spring Boot 2.7.x | Undertow | Mojarra 2.3.x
Mac OS, Firefox and Chromium

User avatar
w00f
Posts: 307
Joined: 27 Apr 2016, 13:27
Contact:

25 May 2017, 14:01

bjorntj wrote:
25 May 2017, 13:35
Ok, thx.. :)
No problem. 🐿

User avatar
bjorntj
Posts: 277
Joined: 30 Jul 2010, 10:46

26 May 2017, 09:36

Ok, tried to change the $headerBgColor variable but nothing changed. Do I need to do something more?
PrimeFaces 11.x | PrimeVue 3.x | Spring Boot 2.7.x | Undertow | Mojarra 2.3.x
Mac OS, Firefox and Chromium

Post Reply

Return to “Verona - PrimeFaces”

  • Information
  • Who is online

    Users browsing this forum: No registered users and 5 guests