Page 1 of 1

Calendar is missing red border in invalid state

Posted: 01 Oct 2017, 15:14
by bossqone
Image
Calendar component itself has these classes: ng-dirty ng-invalid ng-touched
I would suggest to fix validation classes like this:

Code: Select all

// actual code:
p-calendar.ng-dirty.ng-invalid > .ui-inputtext

// fixed code
p-calendar.ng-dirty.ng-invalid > .ui-calendar > .ui-inputtext
Maybe one more question, do we need direct child selector?
I mean, it just causes compatibility issues when HTML structure of components has been changed in PrimeNG and wasn't reflected to the theme.

Re: Calendar is missing red border in invalid state

Posted: 09 Oct 2017, 15:02
by merve7
Thank you. Yes, we need child selector because if we dont have child selector, need only ui-inputtext but now we need ui-inputtext inside in the ui-calendar.

Re: Calendar is missing red border in invalid state

Posted: 17 Oct 2017, 13:39
by bossqone
I'm not sure what do you mean. Like, I understand that child selector is currently needed (due to current implementation), but it is needed at all? It's too strict/limiting.

Re: Calendar is missing red border in invalid state

Posted: 01 Dec 2017, 12:06
by cagatay.civici
Fixed for Poseidon 5.0 due next week.