SharedModule naming conflict

Post Reply
krisp
Posts: 5
Joined: 04 Jan 2018, 18:05

26 Apr 2018, 18:14

Hi there,

The angular style guide encourages a CoreModule for singleton services and a SharedModule for barreling commonly used components. I ran into the conflict with the Atlantis SharedModule already found in the theme's app module imports. So I've named my app's SharedModule something else for now.

So just wanted to raise this as a feedback item. Please consider changing this in future and look at evolving the themes to better fit with the official Angular style guide.

Kris

User avatar
aragorn
Posts: 3413
Joined: 29 Jun 2013, 12:38

22 May 2018, 09:57

Thanks a lot for the feedback, we'll check and get back to you.

Best Regards,

Post Reply

Return to “Atlantis - PrimeNG”

  • Information
  • Who is online

    Users browsing this forum: No registered users and 1 guest