Page 1 of 1

SharedModule naming conflict

Posted: 26 Apr 2018, 18:14
by krisp
Hi there,

The angular style guide encourages a CoreModule for singleton services and a SharedModule for barreling commonly used components. I ran into the conflict with the Atlantis SharedModule already found in the theme's app module imports. So I've named my app's SharedModule something else for now.

So just wanted to raise this as a feedback item. Please consider changing this in future and look at evolving the themes to better fit with the official Angular style guide.

Kris

Re: SharedModule naming conflict

Posted: 22 May 2018, 09:57
by aragorn
Thanks a lot for the feedback, we'll check and get back to you.

Best Regards,