Angular CLI support - Linting

Post Reply
rwngallego
Posts: 3
Joined: 07 Jul 2017, 06:58

09 Jul 2017, 06:44

As you've stated on the theme description this theme is supported with Angular CLI, is this possible that you fix the linting of the template you're delivering according to the linting standards of Angular CLI?

Code: Select all

paradise-ng-1.0.1$ ng lint

/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/domain/car.ts[6, 2]: file should end with a newline
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/service/carservice.ts[30, 2]: file should end with a newline
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/service/carservice.ts[7, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/service/eventservice.ts[15, 2]: file should end with a newline
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/service/eventservice.ts[6, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[64, 2]: file should end with a newline
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[12, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[14, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[16, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[18, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[20, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[22, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[26, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[29, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[31, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[38, 85]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[39, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[1, 19]: missing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[30, 76]: missing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[33, 33]: missing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[33, 54]: missing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[34, 33]: missing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[34, 51]: missing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[34, 55]: missing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[35, 33]: missing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[35, 47]: missing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[35, 51]: missing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[36, 33]: missing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[36, 49]: missing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[36, 53]: missing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[37, 33]: missing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[37, 51]: missing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[37, 55]: missing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[38, 33]: missing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[38, 48]: missing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[38, 52]: missing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/dashboarddemo.ts[11, 14]: The name of the class DashboardDemo should end with the suffix Component (https://goo.gl/5X1TE7)
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/service/countryservice.ts[15, 2]: file should end with a newline
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/service/countryservice.ts[6, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/service/nodeservice.ts[22, 2]: file should end with a newline
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/service/nodeservice.ts[6, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/service/nodeservice.ts[15, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[216, 11]: comment must start with a space
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[226, 2]: file should end with a newline
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[216, 1]: Exceeds maximum line length of 140
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[12, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[14, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[16, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[18, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[22, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[24, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[26, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[28, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[30, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[34, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[36, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[38, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[40, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[44, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[46, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[48, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[50, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[52, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[54, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[56, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[58, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[60, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[62, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[64, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[66, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[74, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[82, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[84, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[90, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[102, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[107, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[122, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[128, 38]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[155, 41]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[156, 43]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[159, 47]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[194, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[207, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[209, 33]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[214, 1]: trailing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[209, 13]: Identifier 'query' is never reassigned; use 'const' instead of 'let'.
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[219, 17]: Identifier 'country' is never reassigned; use 'const' instead of 'let'.
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[217, 13]: Identifier 'filtered' is never reassigned; use 'const' instead of 'let'.
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[220, 72]: == should be ===
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[217, 21]: expected nospace before colon in variable-declaration
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[1, 19]: missing whitespace
/home/rgallego/Sandbox/angular2/paradise-ng-1.0.1/src/app/demo/view/sampledemo.ts[6, 20]: missing whitespace
...
... MESSAGE TOO LONG TO BE PASTED HERE
...
Regards,

Rowinson Gallego

User avatar
DarthMaul
Posts: 583
Joined: 23 Nov 2015, 21:20

10 Jul 2017, 08:25

Hi,

Yes, definitely we can do that for next release.

Regards

rwngallego
Posts: 3
Joined: 07 Jul 2017, 06:58

15 Jul 2017, 02:39

I managed to fix most of them by using:

ng lint --fix

:)

I was not able to fix the problem with the "app-submenu" directive though.

User avatar
optimus.prime
Prime
Posts: 17556
Joined: 05 Jan 2009, 00:21
Location: Cybertron
Contact:

08 Sep 2017, 16:33

In next version, we plan to remove these warnings as well.

Post Reply
  • Information
  • Who is online

    Users browsing this forum: No registered users and 1 guest