Page height too high, scrollbar always visible

Post Reply
koesper
Posts: 4
Joined: 20 Feb 2017, 09:41

17 Aug 2017, 14:28

I just noticed that the height of the topbar is always added to the height of a page, and thus you always get a scrollbar.
This is not very visible in the demo, since most pages have a lot of content. But for instance on this page: https://www.primefaces.org/paradise-ng/#/file, you will always see a scrollbar.

(Checked on chrome, safari and firefox, using Paradise 1.1.0)

User avatar
aragorn
Posts: 2658
Joined: 29 Jun 2013, 12:38

18 Aug 2017, 10:00

I'll check and get back to you.

User avatar
aragorn
Posts: 2658
Joined: 29 Jun 2013, 12:38

18 Aug 2017, 10:04

Please try;

Code: Select all

body {
	height: calc(100% - 70px) !important;
}
OR

Please change line 12 in _main.scss. Then, please provide new css files from scss files.

Fixed for next version.

koesper
Posts: 4
Joined: 20 Feb 2017, 09:41

18 Aug 2017, 14:00

That was quick! But now all pages, including those without a topbar are resized. For instance the loading/splashpage now have a 70px white gap at the bottom.
Also, we should put this 70px 'magic number' in a variable (eg. $topbarHeight), so we can also use that on line 23 and 479 of _main.scss (perhaps it is in other locations too?)

User avatar
optimus.prime
Prime
Posts: 17686
Joined: 05 Jan 2009, 00:21
Location: Cybertron
Contact:

08 Sep 2017, 16:29

There should be a better solution so we're discussing how we can improve this, then we'll get back to you.

User avatar
aragorn
Posts: 2658
Joined: 29 Jun 2013, 12:38

28 Sep 2017, 10:22

Fixed for next version.

Post Reply
  • Information
  • Who is online

    Users browsing this forum: No registered users and 1 guest