I just noticed that the height of the topbar is always added to the height of a page, and thus you always get a scrollbar.
This is not very visible in the demo, since most pages have a lot of content. But for instance on this page: https://www.primefaces.org/paradise-ng/#/file, you will always see a scrollbar.
(Checked on chrome, safari and firefox, using Paradise 1.1.0)
Page height too high, scrollbar always visible
Forum rules
Please note that response time for technical support is within 3-5 business days.
Please note that response time for technical support is within 3-5 business days.
-
- Posts: 5281
- Joined: 29 Jun 2013, 12:38
I'll check and get back to you.
Github Profile: https://github.com/mertsincan
-
- Posts: 5281
- Joined: 29 Jun 2013, 12:38
Please try;
OR
Please change line 12 in _main.scss. Then, please provide new css files from scss files.
Fixed for next version.
Code: Select all
body {
height: calc(100% - 70px) !important;
}
Please change line 12 in _main.scss. Then, please provide new css files from scss files.
Fixed for next version.
Github Profile: https://github.com/mertsincan
That was quick! But now all pages, including those without a topbar are resized. For instance the loading/splashpage now have a 70px white gap at the bottom.
Also, we should put this 70px 'magic number' in a variable (eg. $topbarHeight), so we can also use that on line 23 and 479 of _main.scss (perhaps it is in other locations too?)
Also, we should put this 70px 'magic number' in a variable (eg. $topbarHeight), so we can also use that on line 23 and 479 of _main.scss (perhaps it is in other locations too?)
-
- Prime
- Posts: 18616
- Joined: 05 Jan 2009, 00:21
- Location: Cybertron
- Contact:
There should be a better solution so we're discussing how we can improve this, then we'll get back to you.
-
- Posts: 5281
- Joined: 29 Jun 2013, 12:38
Fixed for next version.
Github Profile: https://github.com/mertsincan
-
- Information
-
Who is online
Users browsing this forum: No registered users and 10 guests