Page 1 of 1
Page height too high, scrollbar always visible
Posted: 17 Aug 2017, 14:28
by koesper
I just noticed that the height of the topbar is always added to the height of a page, and thus you always get a scrollbar.
This is not very visible in the demo, since most pages have a lot of content. But for instance on this page:
https://www.primefaces.org/paradise-ng/#/file, you will always see a scrollbar.
(Checked on chrome, safari and firefox, using Paradise 1.1.0)
Re: Page height too high, scrollbar always visible
Posted: 18 Aug 2017, 10:00
by mert.sincan
I'll check and get back to you.
Re: Page height too high, scrollbar always visible
Posted: 18 Aug 2017, 10:04
by mert.sincan
Please try;
Code: Select all
body {
height: calc(100% - 70px) !important;
}
OR
Please change line 12 in _main.scss. Then, please provide new css files from scss files.
Fixed for next version.
Re: Page height too high, scrollbar always visible
Posted: 18 Aug 2017, 14:00
by koesper
That was quick! But now all pages, including those without a topbar are resized. For instance the loading/splashpage now have a 70px white gap at the bottom.
Also, we should put this 70px 'magic number' in a variable (eg. $topbarHeight), so we can also use that on line 23 and 479 of _main.scss (perhaps it is in other locations too?)
Re: Page height too high, scrollbar always visible
Posted: 08 Sep 2017, 16:29
by cagatay.civici
There should be a better solution so we're discussing how we can improve this, then we'll get back to you.
Re: Page height too high, scrollbar always visible
Posted: 28 Sep 2017, 10:22
by mert.sincan
Fixed for next version.