PF13 compatible version
Forum rules
Please note that response time for technical support is within 3-5 business days.
Please note that response time for technical support is within 3-5 business days.
As 13 RC1 has been released, would it be possible to release a 13 compatible version of the theme as well (for testing purposes)?
PrimeFaces Developer | PrimeFaces Extensions Developer
GitHub: https://github.com/jepsar
Spotify: 90s Rave, Acid, Trance, House
GitHub: https://github.com/jepsar
Spotify: 90s Rave, Acid, Trance, House
Any news here?
I was feeling lucky, and tried with PF 13 RC1 with Diamond 4.1.0, but got this error:
ERROR: class org.primefaces.diamond.component.DiamondMenuRenderer tried to access private method 'org.primefaces.util.WidgetBuilder org.primefaces.util.WidgetBuilder.init(java.lang.String, java.lang.String, java.lang.String)' (org.primefaces.diamond.component.DiamondMenuRenderer and org.primefaces.util.WidgetBuilder are in unnamed module of loader org.glassfish.web.loader.WebappClassLoader @36a98ac8)
java.lang.IllegalAccessError: class org.primefaces.diamond.component.DiamondMenuRenderer tried to access private method 'org.primefaces.util.WidgetBuilder org.primefaces.util.WidgetBuilder.init(java.lang.String, java.lang.String, java.lang.String)' (org.primefaces.diamond.component.DiamondMenuRenderer and org.primefaces.util.WidgetBuilder are in unnamed module of loader org.glassfish.web.loader.WebappClassLoader @36a98ac8)
So, changes are required.
I was feeling lucky, and tried with PF 13 RC1 with Diamond 4.1.0, but got this error:
ERROR: class org.primefaces.diamond.component.DiamondMenuRenderer tried to access private method 'org.primefaces.util.WidgetBuilder org.primefaces.util.WidgetBuilder.init(java.lang.String, java.lang.String, java.lang.String)' (org.primefaces.diamond.component.DiamondMenuRenderer and org.primefaces.util.WidgetBuilder are in unnamed module of loader org.glassfish.web.loader.WebappClassLoader @36a98ac8)
java.lang.IllegalAccessError: class org.primefaces.diamond.component.DiamondMenuRenderer tried to access private method 'org.primefaces.util.WidgetBuilder org.primefaces.util.WidgetBuilder.init(java.lang.String, java.lang.String, java.lang.String)' (org.primefaces.diamond.component.DiamondMenuRenderer and org.primefaces.util.WidgetBuilder are in unnamed module of loader org.glassfish.web.loader.WebappClassLoader @36a98ac8)
So, changes are required.
PrimeFaces Developer | PrimeFaces Extensions Developer
GitHub: https://github.com/jepsar
Spotify: 90s Rave, Acid, Trance, House
GitHub: https://github.com/jepsar
Spotify: 90s Rave, Acid, Trance, House
PrimeFaces Developer | PrimeFaces Extensions Developer
GitHub: https://github.com/jepsar
Spotify: 90s Rave, Acid, Trance, House
GitHub: https://github.com/jepsar
Spotify: 90s Rave, Acid, Trance, House
You need to change the renderer to
```java
WidgetBuilder wb = getWidgetBuilder(context);
wb.init("Diamond", menu)
.attr("statefulScroll", menu.isStatefulScroll());
wb.finish();
```
```java
WidgetBuilder wb = getWidgetBuilder(context);
wb.init("Diamond", menu)
.attr("statefulScroll", menu.isStatefulScroll());
wb.finish();
```
PrimeFaces Developer | PrimeFaces Extensions Developer
GitHub: https://github.com/jepsar
Spotify: 90s Rave, Acid, Trance, House
GitHub: https://github.com/jepsar
Spotify: 90s Rave, Acid, Trance, House
Any news on this yet?
PrimeFaces Developer | PrimeFaces Extensions Developer
GitHub: https://github.com/jepsar
Spotify: 90s Rave, Acid, Trance, House
GitHub: https://github.com/jepsar
Spotify: 90s Rave, Acid, Trance, House
As PrimeFaces 13 will be released this week, the question will be to get a compatible version so we can upgrade (I really would have liked to test first). I hope we don't need to wait as long as we had to wait for a version 12 compatible version.
PrimeFaces Developer | PrimeFaces Extensions Developer
GitHub: https://github.com/jepsar
Spotify: 90s Rave, Acid, Trance, House
GitHub: https://github.com/jepsar
Spotify: 90s Rave, Acid, Trance, House
-
- Posts: 5281
- Joined: 29 Jun 2013, 12:38
Hi @jasper,
Could you please try;
Could you please try;
Code: Select all
// DiamondMenuRenderer.java
...
@Override
protected void encodeScript(FacesContext context, AbstractMenu abstractMenu) throws IOException {
DiamondMenu menu = (DiamondMenu) abstractMenu;
String clientId = menu.getClientId(context);
HttpServletRequest req = (HttpServletRequest) FacesContext.getCurrentInstance().getExternalContext().getRequest();
String pathname = req.getContextPath() + req.getServletPath();
ResponseWriter rw = context.getResponseWriter();
rw.startElement("script", null);
rw.writeAttribute("id", clientId + "_s", null);
rw.writeAttribute("type", "text/javascript", null);
rw.write("$(function(){");
rw.write("PrimeFaces.cw(\"Diamond\",\"");
rw.write(menu.resolveWidgetVar());
rw.write("\",{id:\"");
rw.write(clientId);
rw.write("\",");
// attrs
rw.write("statefulScroll:");
rw.write(String.valueOf(menu.isStatefulScroll()));
rw.write(",");
rw.write("pathname:\"");
rw.write(pathname);
rw.write("\"");
rw.write("});");
rw.write("});");
rw.endElement("script");
}
...
Github Profile: https://github.com/mertsincan
The Java built issue has been resolved. We reverted the change in the 13 code tree and made the method deprecated.
I guess now it's just a matter of getting the CSS updated.
I guess now it's just a matter of getting the CSS updated.
PrimeFaces Developer | PrimeFaces Extensions Developer
GitHub: https://github.com/jepsar
Spotify: 90s Rave, Acid, Trance, House
GitHub: https://github.com/jepsar
Spotify: 90s Rave, Acid, Trance, House
-
- Information
-
Who is online
Users browsing this forum: No registered users and 0 guests