Should I close StreamedContent stream?

[primehthb]

Hi,

I'm using the FileDownload component. I use the DefaultStreamedContent to keep the file in memory.

Should I at any point close the InputStream manually in this variable, by calling

Code: Select all

file.getStream().close()

, where file is the StreamedContent variable?

[Radek]

Hi,

I have a similar problem with graphicImage component. I think there is a big memory leak, because nobody close open input streams. I want to render image which is saved somewhere in filesystem so I have used FileInputStream but it is easy to get "too many open files"...

I thing that DefaultStreamedContent should return new opened stream each call of getStream method and PrimeResourceHandler should close the stream in the end of method handleResourceRequest.

[cagatay.civici]

PrimeFaces should close it for you after writing the response but it doesn't seem to do that, please create an issue ticket and post the issue link here.

Thanks.

[phanisk]

Is this defect fixed? If so can someone please point to me in which version it got fixed?

I am trying to display an image through DefaultStreamedContent and passing a new InputStream. Seems I don't have any control over to close this stream unless Primefaces closes the stream after reading the content. Otherwise it would lead to very serious issues.

Please reply.

[kukeltje]

if an issue was not created, the chance is big it was not fixed... So check the issue list and see if and when it got fixed. If so, you can kind of make a guestimate which version it got fixed in. If not, please create an issue

[cagatay.civici]

Issue fixed;

http://code.google.com/p/primefaces/iss ... il?id=4394

[Oleg]

Good to see Cagatay on heavy bug fixing

[cagatay.civici]

I think 3.4 has enough new features

[Oleg]

I think 3.4 has enough new features

Very right vision!

[kukeltje]

And he even creates the 'issues' himself at google